Standardize method names for 3DTiles metadata #10473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @jjhembd!
Reviewers, don't forget to make sure that:
|
There was a problem hiding this comment.
Now that we're standardizing on property IDs, we should also rename the Specs/Data/Cesium3DTiles/PointCloud/PointCloudWithUnicodePropertyNames to use "IDs" instead of "Names". The specs that use that sample data will also need to be updated.
Otherwise, this is looking great @jjhembd. Just a couple of minor changes needed.
|
Thanks @sanjeetsuhag! I renamed the sample data files, and updated the specs accordingly. Let me know if you see anything else. |
sanjeetsuhag
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
All the relevant Sandcastles work as expected and the documentation looks good. Thanks @jjhembd!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
.getPropertyIdsmethods to the classes Cesium3DTileFeature, Cesium3DTilePointFeature, and ModelFeature, for better consistency with other3DTiles_metadataclasses.The existing
.getPropertyNamesmethods are still present, but deprecated.Resolves #9914